Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GitHub releases with multiple signatures #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lkrms
Copy link

@lkrms lkrms commented Feb 2, 2024

This fixes phive install doctum, at least, but I'm not sure how common releases with multiple signatures are; it may be worth incorporating the same fix into other repositories?

@theseer theseer self-assigned this Feb 14, 2024
@theseer
Copy link
Member

theseer commented Mar 1, 2024

I'll try to incorporate that hopefully next week.

@lkrms
Copy link
Author

lkrms commented Mar 1, 2024

Sounds good. Would you like me to replicate the fix for other repositories?

Also, the QA failure looks like the same issue I had getting a test environment working--the version of PHPStan in phive.xml is too old to appear in the first page of GitHub's release endpoint response. Easy fix is to update phive.xml; less easy fix is to incorporate paging into PHIVE's HTTP client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants